Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fastload setting and change loading from ugly text to responsive and beatiful icon #1434

Merged
merged 5 commits into from
Mar 8, 2024

Conversation

ccuser44
Copy link
Contributor

@ccuser44 ccuser44 commented Mar 6, 2024

Remove fastload setting and change loading from ugly text to responsive and beatiful icon

@Dimenpsyonal
Copy link
Member

Nope.

@ccuser44
Copy link
Contributor Author

ccuser44 commented Mar 6, 2024

Nope.

Why?

@Dimenpsyonal
Copy link
Member

Because some people might want to continue the regular load
Also for bug reasons

@Dimenpsyonal Dimenpsyonal added ✨ enhancement Enhancing or improving existing functionality 📱 UI Frontend Adonis user interfaces 🚩 discontinuation Deprecation or removal of an existing feature or function labels Mar 6, 2024
@ccuser44
Copy link
Contributor Author

ccuser44 commented Mar 6, 2024

Because some people might want to continue the regular load

But I don't see any good reason for people wan't to continue it. It functions the same as before expect it's faster and less buggy.

@ccuser44 ccuser44 requested a review from Dimenpsyonal March 6, 2024 13:11
@Dimenpsyonal
Copy link
Member

Some people might want to not use the loading icon and instead just want the UI

@Dimenpsyonal Dimenpsyonal added the ⌛needs PoF This PR is awaiting proof of functionality label Mar 7, 2024
@ccuser44
Copy link
Contributor Author

ccuser44 commented Mar 8, 2024

Some people might want to not use the loading icon and instead just want the UI

But, why?

@Dimenpsyonal
Copy link
Member

So hard-loading can still be available

@Dimenpsyonal Dimenpsyonal merged commit d5be49b into Epix-Incorporated:master Mar 8, 2024
2 checks passed
Dimenpsyonal added a commit that referenced this pull request Mar 11, 2024
* v252 changelog

* Update version to v252

* Add Dangerous as command option

* Add Dangerous to command t.bool

* Disable R15 dog

* Make Output functions actually work

* Add colon

* Add output title

* Add output title

* Update output titles

* Made ping readout show in ms (#1420)

Before it would always show 0, this remedy's that

Also sunk in a little grammar fix

* Update Changelog

* Add Dangerous command option (#1418)

* Add WarnDangerousCommand to defaultsettings

* Add WarnDangerousCommand to settings

* Add Dangerous as command option

* Fix !rejoin regarding max player server count (#1415)

* Disable !rejoin when player count is equal or greater than max server players

This is to patch a bug inside roblox where players can have way too many players in it.

* Update DefaultSettings.lua

1/2

* Update DefaultSettings.lua

1.5/2

* Update settings.lua

1.75/2

* Implement setting to disable rejoin at max players

2/2

* Add DisableRejoinAtMaxPlayers to Order and Descs

* Add DisableRejoinAtMaxPlayers to order and descs

---------

Co-authored-by: Dimenpsyonal <64012878+Dimenpsyonal@users.noreply.github.com>

* Update Changelog

* Lazy load userpanel (#1407)

* Lazy load userpanel

* Update UserPanel.lua

* Fix missing variable

* Optimise code

* Fix invalid properties

* Fix hardcoded prefix

* Only get variables if there is a window

* Re-add hardcoded prefix

---------

Co-authored-by: Dimenpsyonal <64012878+Dimenpsyonal@users.noreply.github.com>

* Update Changelog v252

* Update Functions output

* Update ScriptEditor output

* Delete MainModule/Server/Plugins/ServerNewDex.rbxmx

* Update newdex

Remove capitalisation from commands and add :newdex as a command

* Update changelog

* Add title to WindowsXP output

* Turn richtext on for windowsXP

* Add

* Add additional Output features to Steampunk

* Add additonal Output features to Rounded

* Add additional output functions to Aero

* Add additional output functions to Unity

* Update Changelog

* Disable singer by default

* Keybinds input fix (#1422)

* Keybinds input fix

Fixes issue where after selecting a key it would still continuously wait for keys to be input.

* Small Old logs fix

Should check if it's a string instead of any other type.

* Update Changelog

* Add Setting "ChatCreateRobloxCommands" to configure whether or not one wants Roblox Chat Commands to be generated (#1423)

* Add "ChatCreateRobloxCommands"

* Add "ChatCreateRobloxCommands"

* Setting "ChatCreateRobloxCommands" to determine whether or not to create Roblox Chat Commands

* Add a setting to determine whether or not to create Roblox Chat Commands

* Update Changelog

* Add FastLoadUserpanel to variables

* Add FastLoad Userpanel to client settings

* Add default value if var is blank

* Fix typo

* Option to disable FastLoad

* Update logic

* Silence playerdata error

* Silence errors

* Update Changelog

* Change meta files from Disabled to Enabled (#1424)

* Update enabled to disabled

* Swap around layout

* Update Changelog

* Fix text being editable in lists (#1425)

* Update Changelog

* Make dangerous commands prompt before being executed. (#1426)

* Add mark as dangerous functionality

* Fix linter issue

* Add WarnDangerousCommand setting

* Add dangerous tags to commands.

* Move dangerous command warning from `Admin.RunCommandAsPlayer` to `Process.Command`

* Fix linter errors.

* Whoops, haven't seen that one.

* Remove dangerous checks from direct ban related commands.

* Bug fixes.

Co-authored-by: fxeP1 <fxe@riseup.net>

---------

Co-authored-by: fxeP1 <fxe@riseup.net>

* Update description of `:nil` command. (#1427)

* Deprecate :nil

* Update Admins.lua

* Update Changelog

* Update Changelog, include contributors

* Move the sword command into fun commands. (#1428)

* Revert "Fix text being editable in lists (#1425)" (#1432)

This reverts commit 99ff7e0.

* Update Changelog.

* Update Changelog

* Read HttpEnabled directly

* Fix :unfly command not working when SignalBehavior is set to Deferred (#1436)

* Update Changelog

* Remove fastload setting and change loading from ugly text to responsive and beatiful icon (#1434)

* Remove `fastloaduserpanel`

* Remove `fastloaduserpanel`

* Remove `fastloaduserpanel`

* Change loading from text to icon

* Fix typo

* Fix rejoin, again, now another command. (#1438)

* Untrack fix for specific players (#1440)

Resolves issue where missing `_` would prevent the "untrack" command from properly removing the tracking instance.

* Use :GetNetworkPing() accurately (#1439)

* Update Changelog.lua

* Fix title logic

* Fix title logic

* Update title logic

* Update title logic

* Update title logic

* Update title logic

* Update Changelog date and time

* Update Anti_Cheat.lua

---------

Co-authored-by: Drew Bokman <61132894+DrewBokman@users.noreply.github.com>
Co-authored-by: Radiant <69520693+RadiantUwU@users.noreply.github.com>
Co-authored-by: ccuser44 <68124053+ccuser44@users.noreply.github.com>
Co-authored-by: fxe <fxep1@riseup.net>
Co-authored-by: karl-police <karl-police2001@bluewin.ch>
Co-authored-by: kaiserandaxl <122803145+kaiserandaxl@users.noreply.github.com>
Co-authored-by: fxeP1 <fxe@riseup.net>
Co-authored-by: joritochip <83682212+joritochip@users.noreply.github.com>
Co-authored-by: Clown <fatestheadfatheadgaming@gmail.com>
Co-authored-by: Coasterteam <21298244+coasterteam@users.noreply.github.com>
@ccuser44 ccuser44 deleted the patch-1 branch November 3, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚩 discontinuation Deprecation or removal of an existing feature or function ✨ enhancement Enhancing or improving existing functionality ⌛needs PoF This PR is awaiting proof of functionality 📱 UI Frontend Adonis user interfaces
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants