Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for :freecam locking mouse in the center of the screen due to shift-lock activation #1519

Merged
merged 2 commits into from
May 13, 2024

Conversation

sqikerz
Copy link
Contributor

@sqikerz sqikerz commented May 11, 2024

I was recently informed of a bug where if you turn on free-cam while you have shift-lock on, it will lock your mouse to the center of your screen (and it will stay locked until you do the bug again or rejoin).

After fixing this, I also found out that the reverse happens, where shift-lock can be toggled while in free-cam, and if you exit freecam during this, the same issue occurs.

I have thoroughly tested this—no more cursor locks.

@sqikerz
Copy link
Contributor Author

sqikerz commented May 11, 2024

Found another issue (ensures camera moves with mouse in freecam without holding right click. Also when it forced you to hold right click, it will break if you release before you toggle off freecam). This has been fixed now.

Tested thoroughly with these changes, I see no more issues.

@sqikerz
Copy link
Contributor Author

sqikerz commented May 11, 2024

This is extremely hard to show but you can somewhat see my mouse getting locked prior to the fix (after I disable debugmode)

Before fix (0:23):
https://youtu.be/rKd1Iv1kj28

After fix:
https://youtu.be/65XnvktZOBY

@Dimenpsyonal Dimenpsyonal added 🐛 bug Bugs or broken features ⌛needs PoF This PR is awaiting proof of functionality labels May 12, 2024
@sqikerz
Copy link
Contributor Author

sqikerz commented May 13, 2024

This is extremely hard to show but you can somewhat see my mouse getting locked prior to the fix (after I disable debugmode)

Before fix (0:23): https://youtu.be/rKd1Iv1kj28

After fix: https://youtu.be/65XnvktZOBY

@Dimenpsyonal ^ for PoF, is there anything else needed?

@Dimenpsyonal Dimenpsyonal removed the ⌛needs PoF This PR is awaiting proof of functionality label May 13, 2024
@Dimenpsyonal Dimenpsyonal merged commit cb2d1f5 into Epix-Incorporated:master May 13, 2024
2 checks passed
@sqikerz sqikerz deleted the freecam-patch branch May 13, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Bugs or broken features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants