Fixed :unfreecam breaking player's camera when they had it toggled off (and added mandatory feedback when run) #1527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ved (not obvious, this feedback is needed)
|
(ignore the roblox alt, was avoiding the built-in freecam due to studio access) After: |
|
fuck you dont fix this im fixing it myself. My bug report my issue. |
LOL you did have like 1.5 years tbf 😋 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that
:unfreecamwas broken, so I looked at the discord, and it seems like it has been broken since 2022 (ref. https://discord.com/channels/81902207070380032/1024709526827585597)This is caused when freecam is currently toggled off when
:unfreecamis ranAlso removed the binds during the removal of it internally, making it so the user can't get stuck inside freecam if they time it correctly (by toggling it right after it queues StopFreecam(), but prior to deletion)
Lastly, removed the CommandFeedback check so the user is aware that their freecam was removed (specifically in cases where they are not currently in it)