Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove :cut command #1590

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Remove :cut command #1590

merged 1 commit into from
Aug 27, 2024

Conversation

PurpleCreativity
Copy link
Contributor

@PurpleCreativity PurpleCreativity commented Aug 27, 2024

No one uses it, it adds "blood" to your game, which roblox could get mad about (i know the blood effect is shit but this is roblox we're talking about)
2024-08-27-21-04-7217

also i dont really see anything "fun" about theoretically cutting a roblox player and making them bleed

(i dont believe removing a command that doesn't integrate with anything else in adonis requires proof of functionality)

@PurpleCreativity
Copy link
Contributor Author

also the code is shit 😄👍

@Dimenpsyonal
Copy link
Member

are you just trying to get contributor

@PurpleCreativity
Copy link
Contributor Author

no one of my friends suggested this so i pr'd it i dont think this deserves contributor lmao

@PurpleCreativity
Copy link
Contributor Author

code is ancient + the idea behind it is creepy (at least in my opinion)

@Dimenpsyonal Dimenpsyonal added the 🚩 discontinuation Deprecation or removal of an existing feature or function label Aug 27, 2024
@Dimenpsyonal
Copy link
Member

i agree

@PurpleCreativity
Copy link
Contributor Author

ill get contributor another way, soon...

@PurpleCreativity
Copy link
Contributor Author

@Dimenpsyonal i haven't contributed to open source before can i delete my fork when this gets merged

@PurpleCreativity
Copy link
Contributor Author

no idea how it works lol

@Dimenpsyonal
Copy link
Member

yea probably

@Dimenpsyonal Dimenpsyonal merged commit c332e49 into Epix-Incorporated:master Aug 27, 2024
2 checks passed
@P3tray
Copy link
Contributor

P3tray commented Aug 28, 2024

@Dimenpsyonal i haven't contributed to open source before can i delete my fork when this gets merged

Yes, you can. But it gives you free code flex.

@PurpleCreativity
Copy link
Contributor Author

I can flex how much i've contributed with removing a few lines

@P3tray
Copy link
Contributor

P3tray commented Aug 29, 2024

I can flex how much i've contributed with removing a few lines

Contributed? You've detracted from Adonis. Thank you for your help.

@Expertcoderz Expertcoderz added the ⚡ command Specific Adonis commands label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚡ command Specific Adonis commands 🚩 discontinuation Deprecation or removal of an existing feature or function
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants