Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix command quotes showing up in other args #1766

Merged
merged 2 commits into from
Nov 24, 2024

Conversation

WalkerOfBacon
Copy link
Contributor

Fixes #1660

PoF:
image
image

@Dimenpsyonal
Copy link
Member

stupidly simple fix grr...

@Dimenpsyonal Dimenpsyonal merged commit 7d7c184 into Epix-Incorporated:master Nov 24, 2024
2 checks passed
@WalkerOfBacon
Copy link
Contributor Author

stupidly simple fix grr...

IKR

@WalkerOfBacon WalkerOfBacon deleted the patch-3 branch November 24, 2024 21:33
@ccuser44
Copy link
Contributor

@Dimenpsyonal This likely breaks nightly arg handling
image

@WalkerOfBacon
Copy link
Contributor Author

@Dimenpsyonal This likely breaks nightly arg handling image

how tf

@ccuser44
Copy link
Contributor

@Dimenpsyonal This likely breaks nightly arg handling image

how tf

I ran :sm Sample text

Try to see if it happens on your side (might just be a mistake on my side) but I suspect not

@WalkerOfBacon
Copy link
Contributor Author

I think I fixed it
gonna make a pr rn

@WalkerOfBacon
Copy link
Contributor Author

nvm

@ccuser44
Copy link
Contributor

Did the bug happen on your side too?

@WalkerOfBacon
Copy link
Contributor Author

WalkerOfBacon commented Nov 25, 2024

Yeah

Something in this code is not right and im not sure what it is

if #tab>=num then
    break
elseif #tab>=num-1 then
    table.insert(tab,string.sub(msg,#str+3,#msg))
    continue
end

@WalkerOfBacon
Copy link
Contributor Author

getting somewhere
image
image

although now theres this random space before it which can still break the arg handling
image

@WalkerOfBacon
Copy link
Contributor Author

unless it doesnt and im just worrying for no reason

WalkerOfBacon added a commit to WalkerOfBacon/Adonis that referenced this pull request Nov 25, 2024
Dimenpsyonal pushed a commit that referenced this pull request Nov 26, 2024
* Actually fixed quoted args

A fix for a pr (#1766) I made

* Update Split function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command quote args leave quotes in other args
3 participants