Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add region information in :serverinfo #411

Merged
merged 8 commits into from
Jul 15, 2021
Merged

Add region information in :serverinfo #411

merged 8 commits into from
Jul 15, 2021

Conversation

LolloDev5123
Copy link
Contributor

Roblox 10_07_2021 05_48_20 <-- got inspired by arsenal kiddies
random stuff i make for adonis - Roblox Studio 10_07_2021 06_35_05

-- IMPORTANT --
I do not know if it would be ethical to include an IP Address, it is very possible. I have fear this may be exploitable and make it easier for skids to DDOS servers (already possible)
Second issue: When in studio, the ip could reveal yours to unwanted people, so I don't know if it is good to add one and if we do, we might censor it in studio.

Please note that there may be some bugs, such as error handling, checking if HTTP is on, but on the other hand, this would be a pretty good addition to :serverinfo or :serverdetails.

@LolloDev5123
Copy link
Contributor Author

do note the region and things are approximations so yeah while i do live in italy im not even in apulia or veglie lol

MainModule/Server/Commands/Moderators.lua Outdated Show resolved Hide resolved
MainModule/Server/Commands/Moderators.lua Outdated Show resolved Hide resolved
MainModule/Client/UI/Default/ServerDetails.lua Outdated Show resolved Hide resolved
LolloDev5123 and others added 3 commits July 10, 2021 06:50
Co-authored-by: joritochip <83682212+joritochip@users.noreply.github.com>
Co-authored-by: joritochip <83682212+joritochip@users.noreply.github.com>
Co-authored-by: joritochip <83682212+joritochip@users.noreply.github.com>
Copy link
Collaborator

@joritochip joritochip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

MainModule/Server/Commands/Moderators.lua Outdated Show resolved Hide resolved
Co-authored-by: joritochip <83682212+joritochip@users.noreply.github.com>
@P3tray
Copy link
Contributor

P3tray commented Jul 10, 2021

Sir just add an :IsStudio and if true remove the location info from the list. It also means you can include the IP then.

For some of us leaking our city is quite bad considering their size in rural countries. My home location doesn't exactly have millions living there.

IsStudio would fix that.

@Kw6m
Copy link
Contributor

Kw6m commented Jul 10, 2021

I don't think you can get the players IP... Only the servers IP. If I am wrong do point it out to me please. But if the IP is available to the server. Don't display it. Region sure. But IP? The neanderthal's that would be interested in peoples IP's wouldnt be using it for good.

But yes showing the servers IP does no harm. Showing the servers location also does no harm

@P3tray
Copy link
Contributor

P3tray commented Jul 10, 2021

I don't think you can get the players IP... Only the servers IP. If I am wrong do point it out to me please. But if the IP is available to the server. Don't display it. Region sure. But IP? The neanderthal's that would be interested in peoples IP's wouldnt be using it for good.

But yes showing the servers IP does no harm. Showing the servers location also does no harm

This is the IP for the server. If this is a studio test server than it'll be ran from your pc, and therefore your IP.

Not good for taking screenshots or working in teamcreate "anonymously".

Hence my suggestion.

And technically speaking you can't take IP's from clients.

@Sceleratis
Copy link
Member

I see no harm in showing the server's IP.

@LolloDev5123
Copy link
Contributor Author

It could lead to DDOSING, but hey, an exploiter with a potent enough exploit could already get the IP, so, I can show the IP and coordinates? The city is always an approximation, the only things that are right are the region, country, and timezone, I would personally blur out city, IP, and region when someone is in studio, as you could give too much details when screensharing a playtest.

@coasterteam
Copy link
Collaborator

I see no harm in showing the server's IP.

As long as it's only shown to people with elevated permissions

@Sceleratis
Copy link
Member

Sceleratis commented Jul 10, 2021

It could lead to DDOSING, but hey, an exploiter with a potent enough exploit could already get the IP, so, I can show the IP and coordinates? The city is always an approximation, the only things that are right are the region, country, and timezone, I would personally blur out city, IP, and region when someone is in studio, as you could give too much details when screensharing a playtest.

Um. You can already see the IP of the server you're connected to... no exploits required. So....

Also as to the studio thing I feel like that's kinda niche and would be their own fault, but if it really bothers you, you can just check if they're in studio or not and then return something like "N/A" or "Studio"

@joritochip
Copy link
Collaborator

It could lead to DDOSING, but hey, an exploiter with a potent enough exploit could already get the IP, so, I can show the IP and coordinates? The city is always an approximation, the only things that are right are the region, country, and timezone, I would personally blur out city, IP, and region when someone is in studio, as you could give too much details when screensharing a playtest.

Um. You can already see the IP of the server you're connected to... no exploits required. So....

Also as to the studio thing I feel like that's kinda niche and would be their own fault, but if it really bothers you, you can just check if they're in studio or not and then return something like "N/A" or "Studio"

It is also possible to get the IP of any given server without even connecting to it through the API, so I would agree in saying that having the IP there is not that big of an issue.

@LolloDev5123
Copy link
Contributor Author

Alright, I guess this is ready to be pushed? Senstive data such as Region, IP, City, and ZIP Code are not shown when play testing.

@LolloDev5123
Copy link
Contributor Author

Check this stuff for the last time as this is good to be merged I guess

@Sceleratis Sceleratis merged commit 65a1653 into Epix-Incorporated:master Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants