Client/Service Optimization #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decided to improve Client as Server has had a improvement. `Client`: Removal of some useless tables. (Roblox LSP kept saying it wasn't used and checked and hadn't seemed to be used) Commented out warn override as there isn't a need for it as warn accepts tuples that already tostring the arguments. Simplified `IsMobile` function. `LocalContainer` will specify if its a Local container inside workspace. (to clear confusion if anyone checks with game explorer and sees this folder randomly) `logError` now accepts a tuple that concats its arguments. `LoadModule` will warn if there is a error while requiring. Added some wrap optimizations. `Service`: Simplified `Wrapped` function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client:Removal of some useless tables. (Roblox LSP kept saying it wasn't used and checked and hadn't seemed to be used)
Commented out warn override as there isn't a need for it as warn accepts tuples that already tostring the arguments.
Simplified
IsMobilefunction.LocalContainerwill specify if its a Local container inside workspace. (to clear confusion if anyone checks with game explorer and sees this folder randomly)logErrornow accepts a tuple that concats its arguments.LoadModulewill warn if there is a error while requiring.Added some wrap optimizations.
Service:Simplified
Wrappedfunction.