Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Userpanel update #487

Merged
merged 2 commits into from
Sep 19, 2021
Merged

Userpanel update #487

merged 2 commits into from
Sep 19, 2021

Conversation

Expertcoderz
Copy link
Contributor

@Expertcoderz Expertcoderz commented Sep 11, 2021

Mostly visual improvements. Note: the Studio icons on Get Loader and Get Source buttons are intended to show they are primarily for Roblox devs and not regular players/admins (to reduce possible confusion), if it doesn't look good please suggest an edit to remove them.

image

  • Keybinds & aliases management interface has better selection mechanics
    image

  • Keybinds & aliases added/removed notifications/hints more verbose
    image

  • UserPanel window re-opens automatically upon theme setting change

  • New ForceField material option for donor capes

@LolloDev5123
Copy link
Contributor

Yes! Beautiful update! I would suggest making the Get Source with the Developer Icon and maybe Get Loader with the normal Roblox icon? Since Normal Players who want to make a game could also try it out, and we want more people to get the loader, [troll face] ?

@LolloDev5123
Copy link
Contributor

Another suggestion, that i'll just leave here, would be:
Is there a way to know if the ModuleScript is not official? Just make it hidden, and display it only to HeadAdmins+ a setting that could be turned off could be quickly turned off by the backdoor creator, im not sure what we could do, but checking the integrity of Adonis and the Loader could be a great step in reducing Backdooring/Hijacking

@Sceleratis
Copy link
Member

Another suggestion, that i'll just leave here, would be:
Is there a way to know if the ModuleScript is not official? Just make it hidden, and display it only to HeadAdmins+ a setting that could be turned off could be quickly turned off by the backdoor creator, im not sure what we could do, but checking the integrity of Adonis and the Loader could be a great step in reducing Backdooring/Hijacking

No. There's no way to check that in a way that can't be bypassed/removed without including obfuscated code that also does something important (and thus can't be removed.) For obvious reasons I don't plan to do that. Even checking if the loader is the original or not is a challenge and is ultimately not worthwhile to do as the scope of that falls more onto Roblox's ability to moderate and shouldn't really be something an open source project needs to handle (especially since, really, we can't.)

@LolloDev5123
Copy link
Contributor

LolloDev5123 commented Sep 11, 2021

Alrighty, I didn't plan to obfuscate stuff, but yeah, making it a hard time for backdoors to be implemented should be Roblox's work, since for an open-source project they could just remove the code checking for the moduleid,
Another thing, would it be ethical to shortly just collect usage information such as the amount of donors, games using adonis, etc. to display?

@Sceleratis
Copy link
Member

Sceleratis commented Sep 11, 2021

Alrighty, I didn't plan to obfuscate stuff, but yeah, making it a hard time for backdoors to be implemented should be Roblox's work, since for an open-source project they could just remove the code checking for the moduleid,
Another thing, would it be ethical to shortly just collect usage information such as the amount of donors, games using adonis, etc. to display?

To the first thing, I was saying obfuscating it in some way would be the only way to handle that and even then it'd be easy enough to get rid of it.

To the second thing, if you mean analytics it's not feasible/worthwhile and would ultimately piss people off. No point to waste http requests. There's also no good reason to do it other than satisfying personal curiosity. (I've thought about it, tried to do it briefly (informative failure), and ultimately determined there's no place for analytics collection in an open source project.)

@Sceleratis Sceleratis merged commit e06d400 into Epix-Incorporated:master Sep 19, 2021
@Expertcoderz Expertcoderz deleted the patch-13 branch October 12, 2021 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants