Admin/Commands/Core/Process.lua | Optimizations #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Admin`: switched some string metamethods Cached to some tables that could possibly get huge (depends if on settings and datastores) `Commands`: Switched to getEnv instead of giving the commands env. `Core`: `GetDataStore` will now check if you can actually set Data in studio first before setting to prevent a big warn pileup if they are disabled. Switch of `next` to `pairs` More caching to datastores (datastore entries can get really big in size overtime so having it be pretty fast is essential) `Process`: `OnSpawn` and `OnJoin` will run synchronous to prevent yields to the function. `Service`: Changing of string metamethods.
joritochip
requested changes
Oct 27, 2021
| @@ -1028,8 +1044,9 @@ return function(Vargs) | |||
| end; | |||
|
|
|||
| IsBlacklisted = function(p) | |||
| for i,list in next,Variables.Blacklist.Lists do | |||
| if Admin.CheckTable(p, list) then | |||
| local CheckTable = Admin.CheckTable | |||
There was a problem hiding this comment.
No need to store in variable when it is only being used once
There was a problem hiding this comment.
depends on how big the blacklisted table could be and instead of indexing the admin just to get checktable possibly for a huge amount could take a toll on some performance.
| @@ -591,8 +592,9 @@ return function(Vargs) | |||
| if Variables.Whitelist.Enabled then | |||
| local listed = false | |||
|
|
|||
| for listName, list in next,Variables.Whitelist.Lists do | |||
| if Admin.CheckTable(p, list) then | |||
| local CheckTable = Admin.CheckTable | |||
There was a problem hiding this comment.
No need to store in variable when it is only being used once
`Service`: Service will setfenv inside the called func to prevent some reduced setting of a functions env. `Server`: Removed a few useless tables (LSP said they weren't used) switched from next to ipairs/pairs `Client`: Localized the Localized. Switched from next to ipairs/pairs Prevented WaitForChild from outputting a warning if ever possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Admin:switched some string metamethods
Cached to some tables that could possibly get huge (depends if on settings and datastores)
Commands:Switched to getEnv instead of giving the commands env.
Core:GetDataStorewill now check if you can actually use DataStores in studio first before setting to prevent a big warn pileup if they are disabled.Switch of
nexttopairsMore caching to datastores (datastore entries can get really big in size overtime so having it be pretty fast is essential)
Process:OnSpawnandOnJoinwill run synchronous to prevent yields to the function.Service:Changing of string metamethods.