Convert 12 PTHs on column0 that should be NPTHs #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used KiCad-Diff to quickly identify changes in the PCB, as well as the normal Gerber viewer to diff between the changes and the unmodified project.
I could have squashed the three commits down to one, but my version of kiCad (5.1.5) on Linux seemed to shift the entire project (in .kicad_pcb form) by a small offset, making it difficult to analyze any changes (intentional and otherwise) made to the circuit (this could have been an artifact of the KiCad-Diff). The Gerber viewer showed no translation.
When plotting the Gerber and Drill files, I included ALL layers (even the empty ones) and used the following settings for Gerber:
And for the Drill files:
I diffed in the Gerber viewer against commit 15dacd6; and verified that there were no unexpected changes. The KiCad-Diff did show up a small translation offset for the entire board, but only on the first change (whatever the change) to the board. No matter how many times I tried, and down to literally one operation and then saving; it always translated by the same small amount on the first save. I expect that there is some difference in the way 5.1.5 generates the
.kicad_pcb
file, OR KiCad-Diff (based on python pcbnew) itself had some issue. However, the offset did NOT affect the Gerber files, as no translation shows up there.