mypy: further fixes, now tests passing #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jandom
force-pushed
the
jandom/fix/mypy-typechecking
branch
from
3c10f94 to
cf081bf
Compare
Eric-Canas
reviewed
Jul 29, 2024
| @@ -227,7 +225,7 @@ def detect_and_decode( | |||
| if return_detections: | |||
| return decoded_qrs, detections | |||
| else: | |||
| return decoded_qrs | |||
| return decoded_qrs, None | |||
There was a problem hiding this comment.
It should still returning only one parameter instead of two when return detections is False to avoid including breaking changes
There was a problem hiding this comment.
Will amend in another PR – i think this change got introduced to make the mypy "easier" to manage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.