Fix call to parse_args() #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArgumentParser.parse_args() expects a list or iterable of arguments to parse, rather than individual arguments, so unpacking shouldn't be used when calling that method. This commit removes the unnecessary argument unpacking operator.
|
Hey, thanks! I kinda gave up on this project when I discovered ruff was already planning to do something similar, but I still thought it'd be nice to keep it running. Glad you liked it. |
|
Of course 😄 TBH I would probably just use the ruff rule (since I already have ruff enabled in most of my projects) but I like to help fix things when I run across them, and it's interesting to have a Python implementation to look at. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an error when running tests and this seems to fix it.
Hope this helps! It's a neat idea for a project.