Skip to content

Commit

Permalink
Update Node version requirement to v16 for Gershwin release.
Browse files Browse the repository at this point in the history
  • Loading branch information
mcserep committed Apr 30, 2024
1 parent b9e93d0 commit 11302de
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 10 deletions.
6 changes: 3 additions & 3 deletions doc/deps.md
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ make install -j $(nproc)
```

### Node.js and NPM
Make sure you are using at least version 18 of [Node.js](https://nodejs.org/en/).
Make sure you are using at least version 16 of [Node.js](https://nodejs.org/en/).
Unfortunately only older versions are available in the official Ubuntu repositories
for all supported versions, therefore a separate installation might be required from
[NodeSource](https://github.com/nodesource/distributions).
Expand All @@ -209,7 +209,7 @@ sudo mkdir -p /etc/apt/keyrings
curl -fsSL https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key | sudo gpg --dearmor -o /etc/apt/keyrings/nodesource.gpg

# Create deb repository
NODE_MAJOR=18 # or 20
NODE_MAJOR=16 # or 18, 20
echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_$NODE_MAJOR.x nodistro main" | sudo tee /etc/apt/sources.list.d/nodesource.list

# Run Update and Install
Expand All @@ -218,7 +218,7 @@ sudo apt-get install nodejs
```

You can also download [nvm](https://github.com/nvm-sh/nvm), and run `nvm install`
at the root of the project to use the specified Node version (18.13.0).
at the root of the project to use the specified Node version (16.20.2).


### GTest/Googletest
Expand Down
2 changes: 1 addition & 1 deletion webgui-new/.nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v18.13.0
v16.20.2
4 changes: 2 additions & 2 deletions webgui-new/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

## Prerequisites

Make sure you are using at least version 18 of [Node.js](https://nodejs.org/en/).\
You can also download [nvm](https://github.com/nvm-sh/nvm), and run `nvm install` at the root of the project to use the specified Node version (18.13.0).
Make sure you are using at least version 16 of [Node.js](https://nodejs.org/en/).\
You can also download [nvm](https://github.com/nvm-sh/nvm), and run `nvm install` at the root of the project to use the specified Node version (16.20.2).

## Development

Expand Down
4 changes: 2 additions & 2 deletions webgui-new/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions webgui-new/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"dagre": "^0.8.5",
"devicons-react": "^1.2.5",
"i18next": "^23.2.8",
"next": "~13.5.1",
"next": "~13.5.6",
"react": "^18.2.0",
"react-diff-viewer-continued": "^3.2.6",
"react-dom": "^18.2.0",
Expand All @@ -57,6 +57,6 @@
"thrift": "0.16.0"
},
"engines": {
"node": ">=18"
"node": ">=16"
}
}

0 comments on commit 11302de

Please sign in to comment.