-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google analytics integration in the new webgui #642
Merged
mcserep
merged 14 commits into
Ericsson:master
from
LoremIPsummer:feature/#616/new-google-analytics
Nov 1, 2023
Merged
Google analytics integration in the new webgui #642
mcserep
merged 14 commits into
Ericsson:master
from
LoremIPsummer:feature/#616/new-google-analytics
Nov 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set default theme based on user preference
mcserep
added
Kind: Enhancement 🌟
Target: WebGUI
Issues related to the web frontend.
labels
Oct 8, 2023
mcserep
reviewed
Oct 11, 2023
mcserep
requested changes
Oct 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The event sending works as expected, some minor remarks.
mcserep
approved these changes
Nov 1, 2023
mozesl
pushed a commit
to mozesl/CodeCompass
that referenced
this pull request
Nov 1, 2023
mozesl
pushed a commit
to mozesl/CodeCompass
that referenced
this pull request
Nov 1, 2023
wbqpk3
pushed a commit
to wbqpk3/CodeCompass
that referenced
this pull request
Jul 8, 2024
wbqpk3
pushed a commit
to wbqpk3/CodeCompass
that referenced
this pull request
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google Analytics integration with the react-ga4 library.
The data should be collected in the same format as it was declared in #526.
I didn't implement the
info_tree
event, because on the new GUI, clicking on a word in the editor (a.k.a. firing theclick_on_word
event), automatically brings up the Info tree (and there is no dedicated context menu item for it), so it should be considered a duplicated event.The GA script only loads when the user gives direct consent by clicking on "Accept."
If there is an error during accessing the
ga.txt
file content (it does not exist), the cookie notice won't show up.fixes #616
fixes #530