Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google analytics integration in the new webgui #642

Merged

Conversation

LoremIPsummer
Copy link
Collaborator

@LoremIPsummer LoremIPsummer commented Oct 8, 2023

Google Analytics integration with the react-ga4 library.

The data should be collected in the same format as it was declared in #526.

I didn't implement the info_tree event, because on the new GUI, clicking on a word in the editor (a.k.a. firing the click_on_word event), automatically brings up the Info tree (and there is no dedicated context menu item for it), so it should be considered a duplicated event.

The GA script only loads when the user gives direct consent by clicking on "Accept."
If there is an error during accessing the ga.txt file content (it does not exist), the cookie notice won't show up.

fixes #616
fixes #530

@mcserep mcserep added Kind: Enhancement 🌟 Target: WebGUI Issues related to the web frontend. labels Oct 8, 2023
@mcserep mcserep added this to the Release Gershwin milestone Oct 8, 2023
@mcserep mcserep requested review from mcserep and intjftw October 8, 2023 20:15
webgui-new/next.config.js Outdated Show resolved Hide resolved
@LoremIPsummer LoremIPsummer requested a review from mcserep October 11, 2023 20:32
Copy link
Collaborator

@mcserep mcserep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The event sending works as expected, some minor remarks.

webgui-new/src/i18n/locales/en.json Show resolved Hide resolved
webgui-new/src/server.ts Outdated Show resolved Hide resolved
webgui-new/src/server.ts Outdated Show resolved Hide resolved
@LoremIPsummer LoremIPsummer requested a review from mcserep November 1, 2023 02:11
@mcserep mcserep merged commit c8bdffb into Ericsson:master Nov 1, 2023
7 checks passed
mozesl pushed a commit to mozesl/CodeCompass that referenced this pull request Nov 1, 2023
mozesl pushed a commit to mozesl/CodeCompass that referenced this pull request Nov 1, 2023
wbqpk3 pushed a commit to wbqpk3/CodeCompass that referenced this pull request Jul 8, 2024
wbqpk3 pushed a commit to wbqpk3/CodeCompass that referenced this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Kind: Enhancement 🌟 Target: WebGUI Issues related to the web frontend.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google Analytics events in new frontend GDPR compliance when Google Analytics is enabled
2 participants