Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial implementation of type McCabe (#683) #727

Merged
merged 13 commits into from
Jun 17, 2024
Merged

Initial implementation of type McCabe (#683) #727

merged 13 commits into from
Jun 17, 2024

Conversation

Seeker04
Copy link
Collaborator

@Seeker04 Seeker04 commented Mar 22, 2024 •
edited
Loading

TODO checklist:

  • Write tests - 3fdb63c
  • Handling of nested classes
  • Wait for decision on handling of template classes - 0bf929a
  • Check validity of non-zero values for classes with no user-defined methods - c3cf55e

Closes #683

@mcserep mcserep added Kind: Enhancement 🌟 Plugin: C++ Issues related to the parsing and presentation of C++ projects. Plugin: Metrics Issues related to the code metrics plugin. labels Apr 3, 2024
@mcserep
Copy link
Collaborator

mcserep commented Apr 10, 2024

Handling of nested classes: for now, we should handle nested classes as separate, independent types and not aggregate the complexity.

Wait for decision on handling of template classes: investigate the reason for different values for the same types, e.g. DynArray mentioned at #683 (comment) .

@Seeker04 Seeker04 force-pushed the type-level-mccabe branch from 2216b48 to a185da4 Compare April 13, 2024 20:22
@mcserep mcserep added this to the Upcoming Release milestone Apr 29, 2024
@Seeker04 Seeker04 force-pushed the type-level-mccabe branch from b0e6336 to 00070c1 Compare May 1, 2024 12:49
@Seeker04 Seeker04 marked this pull request as ready for review May 1, 2024 15:51
@Seeker04 Seeker04 requested review from mcserep and intjftw May 1, 2024 15:52
mcserep
mcserep reviewed May 8, 2024
View reviewed changes
Copy link
Collaborator

@mcserep mcserep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks quite good based on the code. Requires further functional testing to complete the review.

plugins/cpp_metrics/model/include/model/cppastnodemetrics.h Show resolved Hide resolved
plugins/cpp_metrics/test/sources/parser/CMakeLists.txt Show resolved Hide resolved
Seeker04 added 10 commits May 10, 2024 23:02
Initial implementation of type McCabe (Ericsson#683)
eca8caf
Don't count implicit methods for type McCabe (Ericsson#683)
e831bd5
Added type McCabe tests (Ericsson#683)
b25fa4e
Minor const related refactor (Ericsson#683)
c596b6b
Iterate over all types instead of all methods, store 0 mccabe values …
0f6b9ed 
…too (Ericsson#683)
Refined entity query at method def lookup to avoid finding types (Eri…
b35644e 
…csson#683)
Added some more tests (Ericsson#683)
ca41f07
Ignore classes that were implicitly instantiated from templates (Eric…
84d3a64 
…sson#683)
Workaround of failed assertion when functions of the same entityHash …
3afc5d2 
…are compiled to different binaries (Ericsson#683)
Both function and type McCabe should be spelled out fully to avoid am…
62406a3 
…biguity (Ericsson#683)
@Seeker04 Seeker04 force-pushed the type-level-mccabe branch from 00070c1 to 62406a3 Compare May 10, 2024 21:24
@Seeker04 Seeker04 requested a review from mcserep May 14, 2024 21:10
@mcserep mcserep merged commit 0b7517d into Ericsson:master Jun 17, 2024
8 checks passed
@mcserep mcserep mentioned this pull request Jun 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@intjftw intjftw intjftw approved these changes

@mcserep mcserep mcserep approved these changes

Assignees
No one assigned
Labels
Kind: Enhancement 🌟 Plugin: C++ Issues related to the parsing and presentation of C++ projects. Plugin: Metrics Issues related to the code metrics plugin.
Projects
None yet
Milestone
Upcoming Release
Development

Successfully merging this pull request may close these issues.

Cyclomatic Complexity at Type Level for C++
3 participants
@Seeker04 @mcserep @intjftw