Notifications for the executed processes #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discookie
force-pushed
the
ericsson/complete-notifications
branch
from
3161d3f to
08095d8
Compare
vodorok
approved these changes
May 4, 2023
| break; | ||
| case ProcessStatus.running: | ||
| this._processStatusChange.fire(ProcessStatus.running); | ||
| case ProcessStatus.queued: |
There was a problem hiding this comment.
Is the above fallthrough on line 280 intentional?
There was a problem hiding this comment.
It is, it's not really a fallthrough, just multiple values executing the same case with no extra code.
|
Please resolve the yarn.lock confilcts then it can be merged. |
Discookie
force-pushed
the
ericsson/complete-notifications
branch
from
08095d8 to
113f134
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added notifications for adding CodeChecker log and analyze commands to the queue, and then executing them.
They are mainly displayed on the sidebar, and there's actions for killing the process or removing them from the queue.