Remove unclosable CodeChecker analysis in progress window #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csordasmarton
force-pushed
the
remove_stop_analysis_window
branch
from
5ecd8bc to
7556efc
Compare
Discookie
reviewed
Jan 31, 2022
There was a problem hiding this comment.
CodecheckerVSCodePlugin/src/backend/executor/process.ts
Lines 21 to 25 in 7556efc
There's some extra logic in the executor process related to showing the progressbar that becomes redundant with this change. This option and its related functions should be removed as well.
On large projects the analysis may take minutes. In this case it is really annyoing for the user to show an unclosable pop-window. Also this information whether an analysis is running is already available in the bottom bar. This patch will remove this pop-up window but will introduce a new tree item on the overview sidebar to stop the analysis.
csordasmarton
force-pushed
the
remove_stop_analysis_window
branch
from
7556efc to
c6ff2a6
Compare
|
@Discookie Done, please check it again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On large projects the analysis may take minutes. In this case it is
really annyoing for the user to show an unclosable pop-window.
Also this information whether an analysis is running is already available
in the bottom bar.
This patch will remove this pop-up window but will introduce a new tree
item on the overview sidebar to stop the analysis.