-
Notifications
You must be signed in to change notification settings - Fork 385
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[client] Handle invalid proxy settings
If `HTTP_PROXY` / `HTTPS_PROXY` environment variables are set and the URL is invalid (e.g.: it doesn't contains a schema like localhost:8001) the client will throw the following exception: ``` 'NoneType' object has no attribute 'rfind' File "/codechecker/build/CodeChecker/cc_bin/CodeChecker.py", line 174, in <module> main(commands) File "/codechecker/build/CodeChecker/cc_bin/CodeChecker.py", line 141, in main sys.exit(args.func(args)) File "//codechecker/build/CodeChecker/lib/python3/codechecker_client/cmd/store.py", line 856, in main traceback.print_stack() ``` From this error message it is hard to understand the real problem. Unfortunately Thrift does not handle the use case when invalid proxy format is used (e.g.: no schema is specified). For this reason we need to verify the proxy format in our side.
- Loading branch information
1 parent
ef1b0b8
commit 804cefd
Showing
2 changed files
with
60 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters