Merge pull request #1530 from csordasmarton/fix-valid-product-endpoin…

…t-names Allow more product endpoint names to be valid
Ericsson · May 2, 2018 · a86d84f · a86d84f
2 parents 263e62b + fc4d6b8
commit a86d84f
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 11 deletions.
diff --git a/libcodechecker/server/routing.py b/libcodechecker/server/routing.py
@@ -47,9 +47,7 @@ def is_valid_product_endpoint(uripart):
     if uripart in NON_PRODUCT_ENDPOINTS:
         return False
 
-    # Like programming variables: begin with letter and then letters, numbers,
-    # underscores.
-    pattern = r'^[A-Za-z][A-Za-z0-9_]*$'
+    pattern = r'^[A-Za-z0-9_]+$'
     if not re.match(pattern, uripart):
         return False
 

diff --git a/tests/functional/products/test_products.py b/tests/functional/products/test_products.py
@@ -98,14 +98,6 @@ def test_add_invalid_product(self):
         )
         product_cfg.connection = dbc
 
-        with self.assertRaises(RequestFailed):
-            product_cfg.endpoint = "_INVALID"
-            self._root_client.addProduct(product_cfg)
-
-        with self.assertRaises(RequestFailed):
-            product_cfg.endpoint = "0foobar"
-            self._root_client.addProduct(product_cfg)
-
         with self.assertRaises(RequestFailed):
             product_cfg.endpoint = "$$$$$$$"
             self._root_client.addProduct(product_cfg)