Skip to content

Commit

Permalink
Merge pull request #1302 from csordasmarton/remove-review-comment
Browse files Browse the repository at this point in the history
Remove review comment column from List of bugs
  • Loading branch information
whisperity authored Jan 18, 2018
2 parents adf9c48 + a0ad260 commit bd8f8db
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions www/scripts/codecheckerviewer/ListOfBugs.js
Original file line number Diff line number Diff line change
Expand Up @@ -164,9 +164,6 @@ function (declare, dom, style, Deferred, ObjectStore, Store, QueryResults,

var review = reportData.reviewData;
reportData.reviewStatus = review.status;
reportData.reviewComment = review.author && review.comment
? review.comment
: review.author ? '-' : '';
});

return reportDataList;
Expand Down Expand Up @@ -267,7 +264,6 @@ function (declare, dom, style, Deferred, ObjectStore, Store, QueryResults,
{ name : 'Severity', field : 'severity', cellClasses : 'severity', width : '15%', formatter : severityFormatter },
{ name : 'Bug path length', field : 'bugPathLength', cellClasses : 'bug-path-length', width : '15%', formatter : bugPathLengthFormatter },
{ name : 'Review status', field : 'reviewStatus', cellClasses : 'review-status', width : '15%', formatter : reviewStatusFormatter },
{ name : 'Review comment', cellClasses : 'review-comment-message compact', field : 'reviewComment', width : '50%' },
{ name : 'Detection status', field : 'detectionStatus', cellClasses : 'detection-status', width : '15%', formatter : detectionStatusFormatter }
];

Expand Down Expand Up @@ -325,7 +321,7 @@ function (declare, dom, style, Deferred, ObjectStore, Store, QueryResults,

var item = this.getItem(evt.rowIndex);
switch (evt.cell.field) {
case 'reviewComment':
case 'reviewStatus':
if (item.reviewData.author) {
var content = util.reviewStatusTooltipContent(item.reviewData);
Tooltip.show(content.outerHTML, evt.target, ['below']);
Expand All @@ -336,7 +332,7 @@ function (declare, dom, style, Deferred, ObjectStore, Store, QueryResults,

onCellMouseOut : function (evt) {
switch (evt.cell.field) {
case 'reviewComment':
case 'reviewStatus':
Tooltip.hide(evt.target);
break;
}
Expand Down

0 comments on commit bd8f8db

Please sign in to comment.