Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3 support #170

Closed
4 tasks done
gyorb opened this issue Nov 25, 2015 · 9 comments · Fixed by #2585
Closed
4 tasks done

python3 support #170

gyorb opened this issue Nov 25, 2015 · 9 comments · Fixed by #2585
Assignees

Comments

@gyorb
Copy link
Contributor

gyorb commented Nov 25, 2015

test and update codechecker if needed

Upgrade steps and requirements:

@Xazax-hun
Copy link
Contributor

thrift 0.10 will be released soon, and it is the first version to support python 3.

@Xazax-hun
Copy link
Contributor

Thrift 0.10 is out and available in the pypi for python 3. Source: https://pypi.python.org/pypi/thrift/0.10.0

The last blocker to support python 3 should be gone.

@whisperity
Copy link
Contributor

It's not gone.

Ubuntu 17.04 Zesty and 17.10 Artful still packages thrift-0.9.x and python2 as python in their system.
Thrift could be compiled from source, and even the generated files of 0.9.1 work with 0.10.0 installed from PIP work in Python2 mode.

However, updating Python and Thrift would help a lot in a pressing API issue about encoding large UTF-8 codepoints, such as #726.

@Xazax-hun
Copy link
Contributor

Thrift 0.11 is already released but it looks like the community is not very quick with packaging it.
There is a 0.10 in debian experimental repositories: https://packages.debian.org/experimental/thrift-compiler
And it is not available in any of the ubuntu versions.

@whisperity
Copy link
Contributor

Debian and Ubuntu isn't about getting the newest versions of everything, philosophically.

@LebedevRI
Copy link
Contributor

Reminder that python2 will be fully and completely EOL in 1 month 12 days.

@gyorb
Copy link
Contributor Author

gyorb commented Nov 19, 2019

yes, we know about it, thanks for the reminder

@hellow554
Copy link

hellow554 commented Feb 10, 2020

Follow-up reminder:

DEPRECATION: Python 2.7 reached the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 is no longer maintained. A future version of pip will drop support for Python 2.7. More details about Python 2 support in pip, can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support

Is there a tracking issue on what's missing for python3?

@gyorb
Copy link
Contributor Author

gyorb commented Feb 10, 2020

Hi,

There is no tracking issue, just a project with some notes I've collected.
I'm working on the port to py3 it is not finished yet (The tests run on my machine successfully).
I still need to cleanup the commits and we are discussing in the team how to handle the generated thrift stubs (py3 stubs need at least thrift 0.11.0, but on Ubuntu LTS that version is not available only 0.9.1).
Probably they will be published to pypi and npm but we still try to figure out what would be the easiest user/developer workflow in case of an api change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants