Handle a Thrift exception if file content contains Unicode char that escapes as \u01?? by b64ing source text #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whisperity
force-pushed
the
unexpected_char
branch
8 times, most recently
from
c270ef0 to
f71d584
Compare
…escapes as \u01?? by b64ing source text
whisperity
force-pushed
the
unexpected_char
branch
from
f71d584 to
240e455
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue appeared to @dkrupp when doing the "show bug's line in diff" for #723.
For example, in FFMpeg, some files' header contains the following line:
œis encoded in Unicode as\u0153, but Thrift's python client used byCodeChecker cmdonly accepts\u00xyin the transmitted JSON, otherwise, anUnexpected token: 1is thrown and the connection dies.Solution is to introduce a new method to encode the file output (optionally) as a base64 string, which in turn can be sent over Thrift via no exceptions and decoded later on.