Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LDAP authenticated users default permissions #3072

Closed
jimis opened this issue Dec 2, 2020 · 5 comments · Fixed by #3120
Closed

LDAP authenticated users default permissions #3072

jimis opened this issue Dec 2, 2020 · 5 comments · Fixed by #3120

Comments

@jimis
Copy link
Contributor

jimis commented Dec 2, 2020

I have setup LDAP authentication in CodeChecker for our organisation. I want to give PRODUCT_ACCESS permission to all users for all projects, so that everybody in the organisation can view and comment on issues.

I see different alternative solutions to this:

  • set global or per-project default permission level, or
  • enable wildcards in the user permission settings
  • create a custom group that includes usernames based on wildcards, for example group "all" that contains .*

Please note that there are no useful groups that all users belong to.

@jimis
Copy link
Contributor Author

jimis commented Dec 3, 2020

The only alternative I see now, is to manually give PRODUCT_ACCESS permissions to every user for every project, which will result to thousands of settings. Is there a better alternative that I might be missing?

@csordasmarton
Copy link
Contributor

@jimis If there is a global LDAP group (e.g.: your_compary_user), it can be used to add access permission for everybody who are in this group. You have to configure it per product:
image

@jimis
Copy link
Contributor Author

jimis commented Dec 8, 2020

@csordasmarton AFAIK there is no such group.

@jimis
Copy link
Contributor Author

jimis commented Dec 10, 2020

Any opinions on the suggested solutions to the problem? I could try and implement something, but I would need some guidance, I've looked into how permissions are queried and it goes through many levels of abstraction...

jimis added a commit to jimis/codechecker that referenced this issue Dec 30, 2020
This creates new groups that users can belong to if their username
matches some regular expression.

Makes it possible to have all users belonging to a group in order to set
default permissions for products.

Solves Ericsson#3072.
@jimis
Copy link
Contributor Author

jimis commented Dec 30, 2020

I went on and implemented a way to create custom groups, that might contain any user we like, based on regular expressions. Let me know what you think.

jimis added a commit to jimis/codechecker that referenced this issue Dec 30, 2020
This creates new groups that users can belong to if their username
matches some regular expression.

Makes it possible to have all users belonging to a group in order to set
default permissions for products.

Solves Ericsson#3072.
jimis added a commit to jimis/codechecker that referenced this issue Jan 9, 2021
This creates new groups that users can belong to if their username
matches some regular expression.

Makes it possible to have all users belonging to a group in order to set
default permissions for products.

Solves Ericsson#3072.
jimis added a commit to jimis/codechecker that referenced this issue Jan 10, 2021
This creates new groups that users can belong to if their username
matches some regular expression.

Makes it possible to have all users belonging to a group in order to set
default permissions for products.

Resolves github issue Ericsson#3072.
jimis added a commit to jimis/codechecker that referenced this issue Jan 10, 2021
This creates new groups that users can belong to if their username
matches some regular expression.

Makes it possible to have all users belonging to a group in order to set
default permissions for products.

Resolves github issue Ericsson#3072.
jimis added a commit to jimis/codechecker that referenced this issue Jan 10, 2021
This creates new groups that users can belong to if their username
matches some regular expression.

Makes it possible to have all users belonging to a group in order to set
default permissions for products.

Resolves github issue Ericsson#3072.
jimis added a commit to jimis/codechecker that referenced this issue Jan 10, 2021
This creates new groups that users can belong to if their username
matches some regular expression.

Makes it possible to have all users belonging to a group in order to set
default permissions for products.

Resolves github issue Ericsson#3072.
@csordasmarton csordasmarton added this to the release 6.16.0 milestone Jan 11, 2021
csordasmarton pushed a commit that referenced this issue Jan 11, 2021
* [server] Add regex_groups authentication option

This creates new groups that users can belong to if their username
matches some regular expression.

Makes it possible to have all users belonging to a group in order to set
default permissions for products.

Resolves github issue #3072.
csordasmarton pushed a commit that referenced this issue Jan 25, 2021
* [server] Add regex_groups authentication option

This creates new groups that users can belong to if their username
matches some regular expression.

Makes it possible to have all users belonging to a group in order to set
default permissions for products.

Resolves github issue #3072.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants