Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cmdline sum command and and test #1010

Merged
merged 1 commit into from
Oct 10, 2017
Merged

fix cmdline sum command and and test #1010

merged 1 commit into from
Oct 10, 2017

Conversation

gyorb
Copy link
Contributor

@gyorb gyorb commented Oct 6, 2017

Resolves #1004

@gyorb gyorb requested review from csordasmarton and bruntib October 6, 2017 15:47
@whisperity whisperity added bugfix 🔨 CLI 💻 Related to the command-line interface, such as the cmd, store, etc. commands labels Oct 7, 2017
@csordasmarton
Copy link
Contributor

LGTM!

However, I found some issues which can be fixed very quickly.

report_filter.isUnique = True

all_checkers_report_filter = ttypes.ReportFilter()

all_checkers_report_filter.isUnique = True
run_filter = ttypes.RunFilter()
if check_names is not None:
    run_filter.names = check_names
    run_filter.exactMatch = True

run_info = {run.name: run for run in client.getRunData(run_filter)}

These bugs can be fixed in this pull request, or we can create another issue to fix it.

@gyorb
Copy link
Contributor Author

gyorb commented Oct 9, 2017

I would keep this pull request for the bug fix only and create separate issues for the modifications you suggested @csordasmarton .

@gyorb gyorb merged commit e840d1f into Ericsson:master Oct 10, 2017
@csordasmarton
Copy link
Contributor

Okay, I created separate issues for these problems: #1025, #1026.

@gyorb gyorb deleted the fix_sum branch October 16, 2017 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix 🔨 CLI 💻 Related to the command-line interface, such as the cmd, store, etc. commands
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants