Refuse uploading too big .zip files #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libcodechecker/libhandlers/store.py
Outdated
| @@ -315,6 +316,11 @@ def main(args): | |||
|
|
|||
| try: | |||
| assemble_zip(args.input, zip_file, client) | |||
|
|
|||
| if os.stat(zip_file).st_size > MAX_UPLOAD_SIZE: | |||
| LOG.error("The result list to upload is too big.") | |||
There was a problem hiding this comment.
Write out the maximum uploadable file size too with an exclamation mark at the end of the sentence.
Xazax-hun
reviewed
Oct 19, 2017
libcodechecker/libhandlers/store.py
Outdated
| @@ -315,6 +316,11 @@ def main(args): | |||
|
|
|||
| try: | |||
| assemble_zip(args.input, zip_file, client) | |||
|
|
|||
| if os.stat(zip_file).st_size > MAX_UPLOAD_SIZE: | |||
| LOG.error("The result list to upload is too big (max: 1GB).") | |||
There was a problem hiding this comment.
Shouldn't the error message depend on the MAX_UPLOAD_SIZE variable?
|
The others items in #840 are already satisfied, So that can be closed. To be exact the 30 sec timeout is not done yet but that shouldn't be relevant, since there is no such a long action during storage. But the timeout can be increased later if needed. |
csordasmarton
approved these changes
Oct 24, 2017
|
LGTM! |
|
I've created a new issue for the missing session improvement. #1072 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #840