Escape sql special like characters #1066
Conversation
csordasmarton
force-pushed
the
sql_escape
branch
from
7a75cfd to
6869c68
Compare
|
|
||
| def escape_like(string, escape_char='*'): | ||
| """Escape the string parameter used in SQL LIKE expressions.""" | ||
| return string.replace(escape_char, escape_char * 2) \ |
There was a problem hiding this comment.
So a * becomes **? How does this affect the query?
If I have csordas*marton as filter and I have csordas*marton and csordasFOOBARmarton as run names in the database I get only the first as result?
There was a problem hiding this comment.
If you have two run names (csordas*marton and csordasFOOBARmarton) you get only the first as result for csordas*marton filter.
There was a problem hiding this comment.
This escaping applies to the run and product names when the user starts typing an infix of these for filtering. I think it is not necessary to accept joker characters in this situation, so it wouldn't be a problem if asterisk is interpreted as an exact character.
| "There should be one run for this test.") | ||
|
|
||
| # Filter runs which name contains `test_files*`. | ||
| test_runs = self.__get_runs('test_files*') |
There was a problem hiding this comment.
I think there could be more tests, e.g. for **, %.
There was a problem hiding this comment.
Okay, I've created a few more test cases.
csordasmarton
force-pushed
the
sql_escape
branch
from
6869c68 to
4e89572
Compare
Closes #902