Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

View run count at the list of runs view #1082

Merged
merged 1 commit into from
Nov 2, 2017
Merged

View run count at the list of runs view #1082

merged 1 commit into from
Nov 2, 2017

Conversation

csordasmarton
Copy link
Contributor

cc_run_count

Closes #1079

@whisperity
Copy link
Contributor

Is this the current run count visible or all from the server? I recall Dojo lazily loading tables for some reason.

@whisperity
Copy link
Contributor

Also, perhaps it could be put into the tab's title? Like on GitHub:
image

But that would also require renaming the tab from "List of runs" to "Runs".

@csordasmarton
Copy link
Contributor Author

@whisperity

  • The run count is the current run count (length of the getRunData function result).
  • I moved the run count to the tab title. That was a great idea 👍
    cc_run_count

whisperity
whisperity requested changes Nov 2, 2017
View reviewed changes
Copy link
Contributor

@whisperity whisperity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the : after Runs, other than that it's nice!

@csordasmarton
Copy link
Contributor Author

Done.
cc_run_count

whisperity
whisperity approved these changes Nov 2, 2017
View reviewed changes
Copy link
Contributor

@whisperity whisperity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's roll.

@bruntib bruntib merged commit 5da0664 into Ericsson:master Nov 2, 2017
@csordasmarton csordasmarton deleted the run_count branch November 6, 2017 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gyorb gyorb gyorb approved these changes

@whisperity whisperity whisperity approved these changes

@bruntib bruntib Awaiting requested review from bruntib bruntib is a code owner

Assignees
No one assigned
Labels
enhancement 🌟 GUI 🎨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@csordasmarton @whisperity @gyorb @bruntib