Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Firefox supported version to 22.0 #1085

Merged
merged 1 commit into from
Nov 3, 2017

Conversation

csordasmarton
Copy link
Contributor

@csordasmarton csordasmarton commented Nov 2, 2017

The latest supported Firefox version is 22.0 (https://ftp.mozilla.org/pub/firefox/releases/22.0/linux-x86_64/en-US/). I have increased the supported browser version to this.

Closes #1084

@bruntib
Copy link
Contributor

bruntib commented Nov 2, 2017

Wouldn't it be worth factoring this version checking code and information message to an external .js file for avoiding code duplication? That could be included by a <script> tag.

@gyorb
Copy link
Contributor

gyorb commented Nov 2, 2017

For which javascript library is this the minimal required version?

The latest supported Firefox version is 22.0. Remove ES6 features from code
to support this.
@csordasmarton csordasmarton force-pushed the firefox_supported_version branch from a3c08c1 to d5564f4 Compare November 3, 2017 09:43
@csordasmarton
Copy link
Contributor Author

@bruntib I moved the compatible code to an external .js file.
@gyorb I replaced some non compatible feature to support older browsers (Firefox >=22.0). What is the minimal version which we would like to support? Now older browsers (<22.0) are throwing errors on Array filter function (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/filter).

@csordasmarton csordasmarton changed the title Increase Firefox supported version to 34.0 Increase Firefox supported version to 22.0 Nov 3, 2017
@gyorb
Copy link
Contributor

gyorb commented Nov 3, 2017

I think 22.0 and above should be fine but please check if the unsupported message is shown properly in older browsers mentioned by @dkrupp in the issue.

@csordasmarton
Copy link
Contributor Author

@gyorb I tested it with Firefox 17.0 and 22.0 (https://ftp.mozilla.org/pub/firefox/releases/17.0/linux-x86_64/en-US/) and the non compatible version messages was shown properly.

@bruntib bruntib merged commit cf64c5e into Ericsson:master Nov 3, 2017
@csordasmarton csordasmarton deleted the firefox_supported_version branch November 6, 2017 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants