Improve plist-to-html's Makefile for multijob and no redundant downloads #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vendor/plist_to_html/Makefile
Outdated
| -z $(DIST_DIR)/codemirror.LICENSE \ | ||
| -o $(DIST_DIR)/codemirror.LICENSE | ||
|
|
||
| clike: $(DIST_DIR)/clike.min.js |
There was a problem hiding this comment.
Why did you create a separate target for this? clike is part of the CodeMirror library. It looks to me that the plist-to-html plugin depends on two libraries: codemirror and clike, but clike is not a library.
I think it would be better to use the codemirror target instead of creating a new one.
There was a problem hiding this comment.
The fact that it was under a mode subfolder under CodeMirror's host must have mislead me when I made this patch.
whisperity
force-pushed
the
plist_to_html_makefile
branch
from
edddff5 to
d131101
Compare
csordasmarton
approved these changes
Nov 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of executing the
curlcalls all the time, act like howMakefiles usually behave: if the "built" files already exist, don't rebuild them. This makes quickly rebuilding CodeChecker a lot faster, and, if more job threads are given, thecurlcalls will also be multithreaded.