Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Severity statistics and csv export #1112

Merged

Conversation

csordasmarton
Copy link
Contributor

  • Showing severity report count at the statistics page.
  • Statistics can be exported to CSV.

cc_sev_statistics

Closes #1104

@whisperity
Copy link
Contributor

The button feels weird for me. It could be that the alignment of the text is off a few pixels, or the colour is too saturated.

@csordasmarton csordasmarton force-pushed the severity_statistics_and_export branch 2 times, most recently from f65e629 to f2e4d86 Compare November 13, 2017 08:39
@csordasmarton
Copy link
Contributor Author

@whisperity You have good eyes to catch pixel alignment problems 😄 I have fixed this and I have also changed the color of the export button:

cc_statistics_export

What do you think?


dom.create('a', {
class : 'export-to export-to-csv',
innerHTML : 'Export: CSV',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good now. I think we could omit the : here.

Copy link
Contributor

@gyorb gyorb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have the same functionality at the command line? I prefer to add the export features there first for easier automation. With the UI buttons users have to do the result download manually if they need. In some cases this can be required, but I still prefer the solutions where automation is possible.

@whisperity
Copy link
Contributor

I think this feature (checker stats) is CodeChecker cmd sum which does have an --output <format> option.

- Showing severity report count at the statistics page and the command line sum.
- Statistics can be exported to CSV on the UI.
@csordasmarton csordasmarton force-pushed the severity_statistics_and_export branch from f2e4d86 to 3b9df49 Compare November 23, 2017 14:44
@csordasmarton
Copy link
Contributor Author

We have a --output <format> option at CodeChecker cmd sum. For more information check the user guide: https://github.com/Ericsson/codechecker/blob/master/docs/user_guide.md#cmd-sum

Copy link
Contributor

@whisperity whisperity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ready to go in the next release after the current one.

@whisperity whisperity added this to the release 6.3 milestone Nov 27, 2017
@Xazax-hun Xazax-hun merged commit 63119e8 into Ericsson:master Nov 28, 2017
@csordasmarton csordasmarton deleted the severity_statistics_and_export branch December 1, 2017 14:08
@gyorb gyorb removed this from the release 6.3 milestone Dec 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants