Don't start server if session_config.json is syntactically incorrect #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruntib
approved these changes
Nov 20, 2017
Xazax-hun
approved these changes
Nov 21, 2017
libcodechecker/server/server.py
Outdated
| @@ -748,6 +749,12 @@ def start_server(config_directory, package_data, port, db_conn_string, | |||
| .format(root_file)) | |||
| root_sha = __make_root_file(root_file) | |||
|
|
|||
| try: | |||
| manager = session_manager.SessionManager(root_sha, force_auth) | |||
| except (IOError, ValueError): | |||
There was a problem hiding this comment.
Actually, we don't.
whisperity
force-pushed
the
bailout-if-sessioncfg-bogus
branch
from
7073802 to
f572483
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the clientside file is badly formatted, execution can still continue, because worst thing that can happen is that there is no automatic password login for the user, which will result in a valid prompt of "Please authenticate".
However, serverside, as @sylvestre pointed out, it's indeed dangerous to default back to unauthenticated and whatever mode.