Generate report hash fix #1235
Merged
Generate report hash fix #1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyorb
suggested changes
Dec 7, 2017
| @@ -1987,7 +1987,7 @@ def massStoreRun(self, name, tag, version, b64zip, force): | |||
| # second time here. Use re-use the | |||
There was a problem hiding this comment.
Where is the first plist parse? Shouldn't that be updated too? Or the comment is outdated?
There was a problem hiding this comment.
The first plist parse is at the client side. We don't have to update those too.
There was a problem hiding this comment.
In that case this comment is outdated here right? We can not reuse the results from the client side.
whisperity
requested changes
Dec 7, 2017
| @@ -102,8 +103,12 @@ def parse_plist(path): | |||
|
|
|||
| # We need to extend information for plist files generated | |||
| # by older clang version (before 3.8). | |||
| file_path = files[diag['location']['file']] | |||
| if source_root is not None: | |||
There was a problem hiding this comment.
if x is not None can be replaced with if x if source_root isn't a boolean.
csordasmarton
force-pushed
the
bug_hash_generate_fix
branch
from
12996a5 to
9f1999e
Compare
gyorb
suggested changes
Dec 8, 2017
| @@ -1987,7 +1987,7 @@ def massStoreRun(self, name, tag, version, b64zip, force): | |||
| # second time here. Use re-use the | |||
There was a problem hiding this comment.
In that case this comment is outdated here right? We can not reuse the results from the client side.
Use files from the zip to generate report hash in case of storing run.
csordasmarton
force-pushed
the
bug_hash_generate_fix
branch
from
9f1999e to
f6a67dd
Compare
gyorb
approved these changes
Dec 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use files from the zip to generate report hash in case of storing run.