Ignore -Werror #1279
Merged
Ignore -Werror #1279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkrupp
requested changes
Jan 8, 2018
libcodechecker/log/option_parser.py
Outdated
| '--serialize-diagnostics': 1, | ||
| # If Clang gives warning on which GCC doesn't then during checking it is | ||
| # considered an error and fails the analysis if the original build contains | ||
| # -Werror flag. |
There was a problem hiding this comment.
This is not a well written English sentence.
I suggest rewriting the comment to:
"Clang gives different warnings than GCC. Thus if this flag is kept, the analysis with Clang can fail even if the compilation passes with GCC. "
dkrupp
approved these changes
Jan 8, 2018
whisperity
added
analyzer 📈
In some cases Clang is stricter than GCC regarding the warning messages. -Werror flag converts these to error messages which thus fail the analysis. That's why -Werror will be ignored from now on.
whisperity
approved these changes
Jan 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases Clang is stricter than GCC regarding the warning messages.
-Werror flag converts these to error messages which thus fail the
analysis. That's why -Werror will be ignored from now on.