Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ctu_failure test not removing its test folder #1303

Merged
merged 1 commit into from
Jan 18, 2018

Conversation

whisperity
Copy link
Contributor

The test workspace has a lingering ctu_failure project folder due to test code layout error.

If you check the output with nocapture=1 in the .noserc (and use the rename of the class in this patch), the following is printed:

Test the failure zip contains the source of imported TU ... Running TestCtuFailure tests in /home/<username>/CodeChecker/codechecker/build/workspace/ctu_failure-s7so2I
'analyze' reported CTU-compatibility? False
Has -analyzer-display-ctu-progress? False
SKIP: CTU is not supported
Test the failure zip contains the source of imported TU and all the ... Running TestCtuFailure tests in /home/<username>/CodeChecker/codechecker/build/workspace/ctu_fail
ure-s7so2I
'analyze' reported CTU-compatibility? False
Has -analyzer-display-ctu-progress? False
SKIP: CTU is not supported
Test that Clang indeed logs the AST import events. ... Running TestCtuFailure tests in /home/<username>/CodeChecker/codechecker/build/workspace/ctu_failure-s7so2I
'analyze' reported CTU-compatibility? False
Has -analyzer-display-ctu-progress? False
SKIP: CTU is not supported
Removing: /home/<username>/CodeChecker/codechecker/build/workspace/ctu_failure-s7so2I
Test full CTU without reparse. ... Running TestCtu tests in /home/<username>/CodeChecker/codechecker/build/workspace/ctu_failure-s7so2I
'analyze' reported CTU-compatibility? False
SKIP: CTU is not supported
Test full CTU with reparse. ... Running TestCtu tests in /home/<username>/CodeChecker/codechecker/build/workspace/ctu_failure-s7so2I
'analyze' reported CTU-compatibility? False
SKIP: CTU is not supported
Test CTU analyze phase without reparse. ... Running TestCtu tests in /home/<username>/CodeChecker/codechecker/build/workspace/ctu_failure-s7so2I
'analyze' reported CTU-compatibility? False
SKIP: CTU is not supported
Test CTU analyze phase with reparse. ... Running TestCtu tests in /home/<username>/CodeChecker/codechecker/build/workspace/ctu_failure-s7so2I
'analyze' reported CTU-compatibility? False
SKIP: CTU is not supported
Test CTU collect phase without reparse. ... Running TestCtu tests in /home/<username>/CodeChecker/codechecker/build/workspace/ctu_failure-s7so2I
'analyze' reported CTU-compatibility? False
SKIP: CTU is not supported
Test CTU collect phase with reparse. ... Running TestCtu tests in /home/<username>/CodeChecker/codechecker/build/workspace/ctu_failure-s7so2I
'analyze' reported CTU-compatibility? False
SKIP: CTU is not supported
Removing: /home/<username>/CodeChecker/codechecker/build/workspace/ctu-haeeWw

This means that the TestCtu class is ran in the ctu_failure folder too, because of how the files are laid out. This results in the CTU-FAILURE folder being removed, but then created again.

@whisperity whisperity added bugfix 🔨 test ☑️ Adding or refactoring tests labels Jan 18, 2018
@whisperity whisperity requested a review from martong January 18, 2018 13:23
@martong martong merged commit 519a1cc into Ericsson:master Jan 18, 2018
@gyorb gyorb added this to the release 6.5 milestone Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix 🔨 test ☑️ Adding or refactoring tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants