Extend command line filters #1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csordasmarton
added
enhancement 🌟
CLI 💻
gyorb
suggested changes
Jan 24, 2018
libcodechecker/libhandlers/cmd.py
Outdated
| parser.add_argument('-s', '--suppressed', | ||
| dest="suppressed", | ||
| action='store_true', | ||
| help="Show only suppressed results instead of only " | ||
| "unsuppressed ones.") | ||
| help="DEPRECATED. Show only suppressed results " |
There was a problem hiding this comment.
I would mention here that the users should use the --filter option to get false positive (suppressed) results.
libcodechecker/libhandlers/cmd.py
Outdated
| "file_paths, detection_statuses, review_statuses " | ||
| "should be a comma separated list, e.g.:" | ||
| "\"high,medium:unix,core:*.cpp,*.h:" | ||
| "new,unresolved:confirmed,wont_fix\"") |
There was a problem hiding this comment.
Since we deprecate the --suppressed option I think we should provide an example filter where we get the false positives.
| if filter_str.count(':') != 4: | ||
| LOG.error("Filter string has to contain four colons (e.g. " | ||
| "\"high,medium:unix,core:*.cpp:new,unresolved:confirmed," | ||
| "wont_fix\").") |
There was a problem hiding this comment.
Please use a false positive filter in the example.
csordasmarton
force-pushed
the
extend-cmd-filters
branch
from
0818275 to
c044527
Compare
* Adding new command line filters for detection status and review status. * Mark `suppressed` option of the command line client as deprecated.
csordasmarton
force-pushed
the
extend-cmd-filters
branch
from
c044527 to
672d940
Compare
gyorb
approved these changes
Jan 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
suppressedoption of the command line client as deprecated.