Multiple run name by using regex at cmd #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csordasmarton
added
enhancement 🌟
CLI 💻
gyorb
suggested changes
Jan 29, 2018
| @@ -48,39 +48,35 @@ def test_filter_run_names(self): | |||
| "There should be two runs for this test.") | |||
|
|
|||
| # Filter runs which name starts with `test_files_`. | |||
| test_runs = self.__get_runs('test_files_') | |||
| test_runs = self.__get_runs('test_files_*') | |||
There was a problem hiding this comment.
Could you add a test where there is no '*' in the run name?
gyorb
suggested changes
Jan 30, 2018
| self.assertEqual(len(test_runs), 1, | ||
| "There should be one run for this test.") | ||
|
|
||
| # Filter runs which name contains `test_files*`. | ||
| test_runs = self.__get_runs('test_files*') | ||
| self.assertEqual(len(test_runs), 1, | ||
| self.assertEqual(len(test_runs), 2, | ||
| "There should be one run for this test.") |
There was a problem hiding this comment.
Please update the message of the assert here.
| test_runs = self.__get_runs('%') | ||
| self.assertEqual(len(test_runs), 1, | ||
| self.assertEqual(len(test_runs), 0, | ||
| "There should be one run for this test.") |
There was a problem hiding this comment.
Please update the message of the assert here.
User can get command line results for multiple runs by using Python regex expression.
csordasmarton
force-pushed
the
cmd-regex-run-names
branch
from
7572ccf to
4766932
Compare
gyorb
approved these changes
Feb 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User can get command line results for multiple runs by using Python regex expression.