refactor plist to plaintext formatting (parse) #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyorb
force-pushed
the
ref-parse
branch
2 times, most recently
from
dec4be4 to
d290f48
Compare
whisperity
added
the
CLI 💻
whisperity
reviewed
Jan 30, 2018
| suppress_data = sp_handler.get_suppressed() | ||
| if suppress_data: | ||
| if self.suppress_handler: | ||
| LOG.info("Writing source-code suppress at '{0}:{1}' to " |
There was a problem hiding this comment.
Is this output true? This should only be printed if --export-suppress is given to parse. What happens if a suppress file is given but we don't want to export into it?
There was a problem hiding this comment.
If a suppress file is given than the report will be printed by parse only if it is not suppressed in the suppress file.
There was a problem hiding this comment.
I understand that. What I meant is the log output here if it holds in execution. I feel this log shouldn't be here.
There was a problem hiding this comment.
I've got your point. I've checked again and removed the log output. It was printed even if the suppress information was not written into a suppress file.
gyorb
force-pushed
the
ref-parse
branch
2 times, most recently
from
cc8c1e3 to
7baae7f
Compare
whisperity
requested changes
Feb 2, 2018
|
Done. |
whisperity
approved these changes
Feb 2, 2018
Plist parsing and formatting used by the old architecture is not the way it should be handled now. It was not flexible and it was hard to improve it. It should be easier to test and setup the output formatting after the changes. Skip lists were not supported by the parse command, this commit will add the skip files support for parse too.
csordasmarton
approved these changes
Feb 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plist parsing and formatting used by the old architecture is not
the way it should be handled now. It was not flexible and it was hard
to improve it.
It should be easier to test and setup the output formatting after the
changes.
Skip lists were not supported by the parse command, this
commit will add the skip files support for parse too.