Remove soft session lifetime completely #1344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whisperity
force-pushed
the
fix-session-handling
branch
from
1bf7cb7 to
47e005c
Compare
csordasmarton
approved these changes
Feb 6, 2018
gyorb
approved these changes
Feb 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1301's removal of
WWW-Authenticatebroke the session handling logic that enabled us to have a soft and a hard life-time. (If the user had a session that soft-expired but didn't hard expire, the login window was infintiely looping.) Due to the server not storing anything user session specific within the session itself (it is just only used to allow privileged access), the soft lifetime's reason "with a login the user could get back settings stored for their session" is moot.soft_expirehas been removed completely from usage. Ifsoft_expireis found in the server configuration, it is ignored. The previous logic ofsession_expirebeing a hard expire now becomes the only expire countdown. If this expires, the user has to log in again no matter what.If soft-expire is ever to be introduced again, the logic on when and exactly how the user needs to be redirected need be revised.