Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use consistent run name filter at cmd line #1417

Merged
merged 1 commit into from
Mar 8, 2018
Merged

Use consistent run name filter at cmd line #1417

merged 1 commit into from
Mar 8, 2018

Conversation

csordasmarton
Copy link
Contributor

  • Filter runs on the server side.
  • Use consistent run name filters.

@csordasmarton csordasmarton added enhancement 🌟 CLI 💻 Related to the command-line interface, such as the cmd, store, etc. commands bugfix 🔨 labels Mar 2, 2018
@csordasmarton csordasmarton added this to the release 6.6 milestone Mar 2, 2018
@csordasmarton csordasmarton requested a review from gyorb March 2, 2018 15:47
@gyorb
Copy link
Contributor

gyorb commented Mar 2, 2018

I think we should enable the * quantifiers for -n NEW_RUN, --newname NEW_RUN command line argument too.

gyorb
gyorb suggested changes Mar 5, 2018
View reviewed changes
Copy link
Contributor

@gyorb gyorb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The filtering tests should be updated too.

@csordasmarton csordasmarton force-pushed the fix-cmd-runname-filter branch from 40da748 to 64d2623 Compare March 5, 2018 11:10
@csordasmarton csordasmarton requested a review from gyorb March 5, 2018 11:26
gyorb
gyorb reviewed Mar 6, 2018
View reviewed changes
Copy link
Contributor

@gyorb gyorb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a simple test where there is a regex expression in the new run name. Otherwise LGTM.

@csordasmarton
Use consistent run name filter at cmd line
e9611c2 
* Filter runs on the server side.
* Use consistent run name filters.
@csordasmarton csordasmarton force-pushed the fix-cmd-runname-filter branch from 64d2623 to e9611c2 Compare March 6, 2018 16:58
@csordasmarton csordasmarton requested a review from gyorb March 6, 2018 16:58
@gyorb gyorb merged commit ebff5ab into Ericsson:master Mar 8, 2018
@csordasmarton csordasmarton deleted the fix-cmd-runname-filter branch March 8, 2018 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gyorb gyorb gyorb approved these changes

Assignees
No one assigned
Labels
bugfix 🔨 CLI 💻 Related to the command-line interface, such as the cmd, store, etc. commands enhancement 🌟
Projects
None yet
Milestone
release 6.6
Development

Successfully merging this pull request may close these issues.
2 participants
@csordasmarton @gyorb