Fix check command clean option #1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csordasmarton
added
CLI 💻
whisperity
reviewed
Mar 5, 2018
libcodechecker/libhandlers/check.py
Outdated
| @@ -490,7 +490,7 @@ def __update_if_key_exists(source, target, key): | |||
| import traceback | |||
| traceback.print_exc() | |||
| finally: | |||
| if is_temp_output: | |||
| if is_temp_output or 'clean' in args: | |||
There was a problem hiding this comment.
How is this change in harmony with line 464:
if 'force' in args:
setattr(analyze_args, 'clean', True)Is there something else that needs to be cleaned and analyze does not clean by itself?
There was a problem hiding this comment.
Yes the cleanup should be set there in line 464.
If the `clean` option is specified for the `CodeChecker check` command clear the output directory.
csordasmarton
force-pushed
the
fix-check-clean
branch
from
651bdab to
be51cd6
Compare
gyorb
approved these changes
Mar 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
cleanoption is specified for theCodeChecker checkcommand clear the output directory.