Use prefix search for run name at the List of runs #1434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of exact match use prefix search at the List of runs page for filtering runs.
gyorb
reviewed
Mar 7, 2018
| @@ -247,7 +247,7 @@ function (declare, dom, ItemFileWriteStore, topic, Dialog, Button, | |||
| var runNameFilter = this.get('value'); | |||
| this.timer = setTimeout(function () { | |||
| var runFilter = new CC_OBJECTS.RunFilter(); | |||
| runFilter.names = [runNameFilter]; | |||
| runFilter.names = [runNameFilter + '*']; | |||
There was a problem hiding this comment.
What it we would use ['*' + runNameFilter + '*'] so you could type partial run names, or we add the extra * somewhere else already to the beginning?
There was a problem hiding this comment.
I think if the user would like to search partially, he should write * quantifier to the input box. This is how the left side filters works on the Bug overview page (like file filter).
There was a problem hiding this comment.
Ok, let's be consistent for every regex filter.
gyorb
approved these changes
Mar 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of exact match use prefix search at the List of runs page for filtering runs.