Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run history command #1500

Merged
merged 1 commit into from
Apr 12, 2018
Merged

Run history command #1500

merged 1 commit into from
Apr 12, 2018

Conversation

csordasmarton
Copy link
Contributor

Creates a separate command to get run history of multiple runs.

Closes #1485

@csordasmarton csordasmarton added enhancement 🌟 CLI 💻 Related to the command-line interface, such as the cmd, store, etc. commands labels Apr 6, 2018
@csordasmarton csordasmarton requested a review from gyorb April 6, 2018 08:22
@whisperity
Copy link
Contributor

run-history appears semantically as if it was a verb and a noun which is misleading. I suggest histories or simply history, or changing "runs" to "list-runs".

Copy link
Contributor

@gyorb gyorb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would vote for history in the command line.

@@ -1336,6 +1337,34 @@ usage: CodeChecker cmd runs [-h] [--url PRODUCT_URL]
List the analysis runs available on the server.
~~~~~~~~~~~~~~~~~~~~~

### <a name="cmd-run-history"></a> List of run history (`run-history`)

With this command you can list out the specific run events which happened during
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe storage events instead of run events?

usage: CodeChecker cmd run-history [-h] [-n [RUN_NAME [RUN_NAME ...]]]
[--url PRODUCT_URL]
[-o {plaintext,html,rows,table,csv,json}]
[-e EXPORT_DIR] [-c]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need the -e EXPORT_DIR here? Is the html output supported?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gyorb I will fix that in a separate pull request because this problem related to multiple command line commands: products list, runs, sum etc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed the html output from here and I have created a separate pull request (#1515) to fix this problem for other commands.

Creates a separate command to get run history of multiple runs.
@gyorb gyorb merged commit 6984fbb into Ericsson:master Apr 12, 2018
@csordasmarton csordasmarton deleted the cmd-run-history branch April 17, 2018 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI 💻 Related to the command-line interface, such as the cmd, store, etc. commands enhancement 🌟
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants