Unified report filter #1510
Merged
Unified report filter #1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyorb
suggested changes
Apr 16, 2018
| baselineFilterToggle.addChild(this._runHistoryTagFilter); | ||
|
|
||
| this._newCheckFilterToggle = new FilterToggle({ | ||
| title : 'Newcheck', |
There was a problem hiding this comment.
What do you think if we would name it Diff to or Compare to?
There was a problem hiding this comment.
- I changed the popup message.
- As we discussed personally, I do not rename 'Newcheck' to 'Compare to'.
- It is better to handle filter items independently. With It should be possible to diff two different tagged versions of the same run #1346 it will be possible to diff results by multiple run tags. Let's assume the user selects multiple run and tag filters for baseline and multiple run and tag filter for newcheck. If the user clears the run filter set for newcheck we do not want to change the diff type filter because multiple run tag filters are selected to newcheck.
csordasmarton
force-pushed
the
common-filter-view
branch
from
9a5f618 to
9699b50
Compare
Creates only one general view (based on the diff view) for report filtering with all the existing diff and filtering features.
csordasmarton
force-pushed
the
common-filter-view
branch
from
9699b50 to
6a5afc9
Compare
gyorb
approved these changes
Apr 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates only one general view (based on the diff view) for report filtering with all the existing diff and filtering features.