Command line deduplication #1517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csordasmarton
added
enhancement 🌟
CLI 💻
csordasmarton
force-pushed
the
cmd-filter-deduplications
branch
from
d93acfa to
80c65b2
Compare
gyorb
suggested changes
Apr 18, 2018
libcodechecker/util.py
Outdated
| @@ -590,3 +590,24 @@ def trim_path_prefixes(path, prefixes): | |||
| return path | |||
|
|
|||
| return path[len(longest_matching_prefix):] | |||
|
|
|||
|
|
|||
| def get_report_path_hash(report, files): | |||
There was a problem hiding this comment.
I think it would be better to put this into libcodechecker/report.py so every report related function is there. It could be a static method of the Report class there.
csordasmarton
force-pushed
the
cmd-filter-deduplications
branch
from
80c65b2 to
c89b8c6
Compare
gyorb
suggested changes
May 4, 2018
libcodechecker/libhandlers/parse.py
Outdated
| @@ -158,7 +158,8 @@ def arg_match(options): | |||
| parser.set_defaults(func=__handle) | |||
|
|
|||
|
|
|||
| def parse(f, context, metadata_dict, suppress_handler, skip_handler, steps): | |||
| def parse(f, context, metadata_dict, suppress_handler, skip_handler, | |||
| processed_path_hashes, steps): | |||
There was a problem hiding this comment.
I would prefer to extend the function arguments at the end if possible. It is really easy to mix up different type of arguments in python.
| @@ -147,6 +146,27 @@ def compare_ctrl_sections(curr, prev): | |||
| return '' | |||
|
|
|||
|
|
|||
| def get_report_path_hash(report, files): | |||
There was a problem hiding this comment.
Please add function documentation.
csordasmarton
force-pushed
the
cmd-filter-deduplications
branch
from
c89b8c6 to
1cfae29
Compare
In the command line (diff and print commands ) the results in the same header files should be shown and counted only once even if they were found multiple times because multiple c/cpp files included them.
csordasmarton
force-pushed
the
cmd-filter-deduplications
branch
from
1cfae29 to
bc1da80
Compare
gyorb
approved these changes
May 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the command line (diff and print commands ) the results in the same header files should be shown and counted only once even if they were found multiple times because multiple c/cpp files included them.
Closes #1465 and Closes #1512.