Give better message when source files are missing #1537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csordasmarton
added
enhancement 🌟
CLI 💻
whisperity
reviewed
Apr 25, 2018
libcodechecker/libhandlers/store.py
Outdated
| LOG.warning("Skipping '{0}' because it contains " | ||
| "a missing source file." | ||
| .format(plist_file)) | ||
| LOG.warning("Skipping '%s' because it contains " |
There was a problem hiding this comment.
contains isn't the right word here from the user's perspective, and wasn't before, either...
Maybe refers?
csordasmarton
force-pushed
the
missing-files-message
branch
from
e009383 to
3c1c0a5
Compare
gyorb
suggested changes
May 2, 2018
libcodechecker/libhandlers/store.py
Outdated
| @@ -189,19 +189,21 @@ def assemble_zip(inputs, zip_file, client): | |||
| file_to_mtime = {} | |||
|
|
|||
| def collect_file_hashes_from_plist(plist_file): | |||
| missing_files = [] | |||
There was a problem hiding this comment.
Please add some function documentation.
csordasmarton
force-pushed
the
missing-files-message
branch
from
3c1c0a5 to
112f9f5
Compare
|
I think it would be useful to list the missing source files at the end of the store log: |
If source files are missing from the system which are in the plist file we should write out the missing file paths too.
csordasmarton
force-pushed
the
missing-files-message
branch
from
112f9f5 to
1ae83cd
Compare
|
@gyorb Done. |
gyorb
approved these changes
May 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If source files are missing from the system which are in the plist file we should write out the missing file paths too.