Removing on-the-fly CTU functionality as it is not supported by clang #1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csordasmarton
suggested changes
May 8, 2018
tests/functional/ctu/test_ctu.py
Outdated
| '--analyzers', 'clangsa', '--ctu-all'] | ||
| if reparse: | ||
| cmd.append('--ctu-on-the-fly') | ||
| '--analyzers', 'clangsa', '--ctu-all','--verbose','debug'] |
There was a problem hiding this comment.
Space is required after ,. Please fix other Codacy warnings too.
tests/functional/ctu/test_ctu.py
Outdated
| '--analyzers', 'clangsa', '--ctu-analyze'] | ||
| if reparse: | ||
| cmd.append('--ctu-on-the-fly') | ||
| '--analyzers', 'clangsa', '--ctu-analyze','--verbose','debug'] |
There was a problem hiding this comment.
Space is required after ,
| @@ -20,8 +20,7 @@ class ClangSAConfigHandler(config_handler.AnalyzerConfigHandler): | |||
| def __init__(self): | |||
| super(ClangSAConfigHandler, self).__init__() | |||
| self.__checker_configs = [] | |||
| self.__ctu_dir = '' | |||
| self.__ctu_in_memory = False | |||
| self.__ctu_dir = '' | |||
There was a problem hiding this comment.
Remove trailing white spaces.
dkrupp
force-pushed
the
remove_ctu_on_the_fly
branch
from
21cad06 to
1c38743
Compare
csordasmarton
approved these changes
May 8, 2018
gyorb
approved these changes
May 8, 2018
|
clang6 does not support this feature yet, if it will be introduced in clang6 or later we should review if we want to re implement is as it was. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.