Skip reports at store #1566
Merged
Skip reports at store #1566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csordasmarton
suggested changes
May 10, 2018
libcodechecker/analyze/analyzer.py
Outdated
| @@ -92,7 +92,11 @@ def __get_skip_handler(args): | |||
| try: | |||
| if args.skipfile: | |||
| LOG.debug_analyzer("Creating skiplist handler.") | |||
| return skiplist_handler.SkipListHandler(args.skipfile) | |||
| skip_handler = None | |||
There was a problem hiding this comment.
It can be written shorter:
with open(args.skipfile) as skip_file:
return skiplist_handler.SkipListHandler(skip_file.read())Please also add a documentation for this function.
| if line.strip() != ''] | ||
| self.__skip_file_lines = [line.strip() for line | ||
| in skip_file.splitlines() | ||
| if line.strip() != ''] |
There was a problem hiding this comment.
To check if a string is empty the following syntax is better: if line.strip()
| for line in skip_file | ||
| if line.strip() != ''] | ||
| self.__skip_file_lines = [line.strip() for line | ||
| in skip_file.splitlines() |
There was a problem hiding this comment.
Rename this variable to skip_file_content and modify the description of the __init__ function too.
| store_handler.metadata_info(metadata_file) | ||
|
|
||
| skiphandler = skiplist_handler.SkipListHandler("") |
There was a problem hiding this comment.
It is not an elegant way to pass an empty string. Instead of this we can handle the case when no parameter is given for this function.
bruntib
reviewed
May 10, 2018
libcodechecker/libhandlers/parse.py
Outdated
| skip_handler = SkipListHandler(args.skipfile) | ||
| with open(skip_file, 'r') as skip_file: | ||
| skip_content = skip_file.read() | ||
| skip_handler = SkipListHandler(skip_file.read()) |
There was a problem hiding this comment.
File read twice unnecessarily.
The skip file content was not used at store. If the same report directory is used without a skip file and with a skip file the reports which should be skipped are stored even if a skip file was used for the second analysis. This change stores the skip file content in the metadata.json so the store in the server can use this information to skip the required reports. Changes in the tests were required to create this use case. This solution still sends all the reports and files to the server and it does report skipping there. It can be improved later where we do more fine grained file detection. Right now the problematic files are mainly the header files which can belong to multiple reports (paths) and if the header file is skipped at the client side of the store the server will not be able to show the missing file when viewing the report.
csordasmarton
approved these changes
May 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The skip file content was not used at store.
If the same report directory is used without a skip file
and with a skip file the reports which should be skipped are
stored even if a skip file was used for the second analysis.
This change stores the skip file content in the metadata.json so
the store in the server can use this information to skip the
required reports.
Changes in the tests were required to create this use case.
This solution still sends all the reports and files to the
server and it does report skipping there.
It can be improved later where we do more fine grained file detection.
Right now the problematic files are mainly the header files
which can belong to multiple reports (paths) and if the
header file is skipped at the client side of the store
the server will not be able to show the missing file when viewing the report.
#948