Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default filter values on run history click #1574

Merged

Conversation

csordasmarton
Copy link
Contributor

If the user clicks on a run history item select default filter values for review status and detection status.

Copy link
Contributor

@gyorb gyorb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check codacy warnings otherwise LGTM.

@csordasmarton
Copy link
Contributor Author

@gyorb CC_OBJECTS variable was defined in the codecheckerviewer.js file and not in the file what I have modified. That's the reason why Codacy shows that it is undefined.

CC_OBJECTS = codeCheckerDBAccess_v6;

If the user clicks on a run history item select default filter values
for review status and detection status.
@csordasmarton csordasmarton force-pushed the run-history-click-default-values branch from eaad596 to a01daf2 Compare May 14, 2018 11:58
@csordasmarton csordasmarton requested a review from gyorb May 14, 2018 11:59
@gyorb gyorb merged commit ba95ead into Ericsson:master May 14, 2018
@csordasmarton csordasmarton deleted the run-history-click-default-values branch May 18, 2018 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants