Create tooltip for some table column #1582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csordasmarton
force-pushed
the
tbl-column-tooltips
branch
from
1b5ea3b to
f8b5f96
Compare
gyorb
suggested changes
May 15, 2018
| + "again with the same run name. When storing the results " | ||
| + "of a run from scratch then each report will have " | ||
| + "detection status of 'New'.", | ||
| numOfUnresolved : "Number of unresolved reports are calculated on the " |
There was a problem hiding this comment.
I think it is easier to understand how the report count is calculated if we write it down like this:
number of non unique reports excluding resolved, false positive and intentional reports
| @@ -14,6 +14,18 @@ function (locale, dom, style, json) { | |||
| 'July', 'August', 'September', 'October', 'November', 'December' | |||
| ]; | |||
|
|
|||
| var tooltips = { | |||
| detectionStatus : "Detection statuses are calculated based on the previous " | |||
There was a problem hiding this comment.
I suggest a small change here:
Detection statuses are calculated based on the detection status values from the previous store where the reports are stored
Create tooltip for the following table columns: * version tag * detection status * number of unresolved reports
csordasmarton
force-pushed
the
tbl-column-tooltips
branch
from
f8b5f96 to
4540669
Compare
gyorb
approved these changes
May 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create tooltip for the following table columns: