Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring filter UI #1586

Merged
merged 1 commit into from
May 16, 2018
Merged

Refactoring filter UI #1586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion www/scripts/codecheckerviewer/filter/BugFilterView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,8 @@ function (declare, lang, Deferred, domClass, dom, domStyle, topic, Button,
//--- Report count ---//

this._reportCount = new ReportCount({
parent : this
parent : this,
class : 'report-count'
});
this.register(this._reportCount);
this.addChild(this._reportCount);
Expand Down
2 changes: 1 addition & 1 deletion www/scripts/codecheckerviewer/filter/ReportCount.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ function (dom, declare, FilterBase) {
dom.create('i', { class : 'customIcon bug' }, wrapper);

this._reportCount = dom.create('span', {
class : 'report-count',
class : 'count',
innerHTML : 0
}, wrapper);
},
Expand Down
20 changes: 14 additions & 6 deletions www/style/bugfilter.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
padding: 0px;
}

.bug-filters > .dijitContentPane {
.bug-filters > .dijitContentPane,
.bug-filters .is-unique {
padding: 5px;
border-bottom: 1px solid rgba(86, 96, 105, 0.23);
}
Expand All @@ -26,6 +27,11 @@
}

/* Clear all button */
.bug-filters .clear-all-btn {
margin-left: 10px;
margin-top: 5px;
display: block;
}

.bug-filters .clear-all-btn > .dijitButtonNode {
background-color: #fff;
Expand All @@ -40,13 +46,15 @@
/* Unique reports checkbox */

.bug-filters .is-unique {
margin-left: 10px;
display: inline-block;
border: none;
padding: 0px;
margin: 10px;
padding: 0 0 10px 0;
vertical-align: middle;
}

.bug-filters .is-unique label {
font-weight: bold;
}

/* All report counter */

.bug-filters .report-count-wrapper {
Expand All @@ -61,7 +69,7 @@
}

.bug-filters .report-count-wrapper .count {
color: #878d96;
font-weight: bold;
}

/* Report filter group */
Expand Down